Handle null when serializing enum to string #6342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanVaknin
added
changelog-not-required
|
Flakey integ test failure |
|
Can we add a changelog entry? Changelog entry is not required only for house keeping changes such as test code or README update |
zoewangg
removed
the
changelog-not-required
|
Can we add a test case in the protocol test , may be src/main/resources/software/amazon/awssdk/protocol/suites/cases/json-core-input.json ? {
"description": "List of enums with null values are marshalled correctly without NPE",
"given": {
"input": {
"ListOfEnums": [
"EnumValue1",
null,
"EnumValue2"
]
}
},
"when": {
"action": "marshall",
"operation": "AllTypes"
},
"then": {
"serializedAs": {
"body": {
"jsonEquals": "{\"ListOfEnums\": [\"EnumValue1\", null, \"EnumValue2\"]}"
}
}
}
}same for maps so we know what we are sending on the wire |
|
Fred1155
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#3861
Modifications
Updated
MemberCopierSpec.javato generate a null check before calling `entry.toString() when serializing enums to strings.Testing